Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(realtime): auto reconnect after calling disconnect, and several refactors #627

Merged
merged 13 commits into from
Jan 8, 2025
Merged

fix(realtime): auto reconnect after calling disconnect, and several refactors #627

merged 13 commits into from
Jan 8, 2025

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Dec 16, 2024 •
edited
Loading

Changes

  • Fix [Realtime] RealtimeV2 auto-reconnects after calling disconnect() #612
  • Refactor internal WebSocket layer by adopting a new WebSocket protocol with a default implementation using URLSession and a fake implementation which makes it easier to write tests
  • Remove async code where it wasn't mandatory, nor were doing good
  • Refactor tests and add integration test for postgres changes

@grdsdev grdsdev changed the title fix(realtime): TBD fix(realtime): auto reconnect after calling disconnect Jan 6, 2025
@grdsdev grdsdev changed the title fix(realtime): auto reconnect after calling disconnect fix(realtime): auto reconnect after calling disconnect, and several refactors Jan 6, 2025
@grdsdev grdsdev marked this pull request as ready for review January 6, 2025 19:40
@grdsdev grdsdev requested a review from dshukertjr January 7, 2025 12:49
@grdsdev grdsdev merged commit 1887f4f into main Jan 8, 2025
22 checks passed
@grdsdev grdsdev deleted the realtime-fixes branch January 8, 2025 10:20
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
@marcprux marcprux mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Realtime] RealtimeV2 auto-reconnects after calling disconnect()
2 participants
@grdsdev @dshukertjr